RC 4: Bug List and fixes

[David]

Hello everyone,

While RC 4 has lots of great new features, we certainly have a number of bugs that we are working quickly to solve for you. Thanks to your donations, it makes it easier for us to get things done as well.

1. Admin Sorting - getting an error when using sort buttons for links and featured links.
(Added into SVN)

2. Reciprocal Links not recognized - when a link is submitted, it is showing it does not exist on the reciprocating page when in fact it does.
(Added into SVN)

3. Admin not gettting emails when a new link is submitted - Fix Below and (Added into SVN)

4. Found a small spelling error - (Added into SVN)

5. Notification when link is deleted - (Added into SVN)

6. Email Template Variable - this is not a bug but nice addition explaining the variables available when using the email templates. (Added into SVN)

7. Text Difficult to Read on Captcha - some changes were submitted to make it a little bit easier to read (Added into SVN)

8. XML Links on Top Hits and Latest Links - just found this bug. The XML is not working on those pages. - (Added into SVN)

9. Changing Features Links to Normal Links in Admin - (Added into SVN)

[minstrel]

Good work, guys...

Anxiously awaiting fix for #3... :o

[Ap0s7le]

Concerning #3.

Try this out, see if it helps.

Open up "include/functions.php"

Edit line 503 that looks like
Content visible to registered users only.

Replace it with
Content visible to registered users only.

Let me know

[springdot]

Ap0s7le, that works a treat - just submitted a test link, and the owner got the submission email, and I got another email to say a link had been submitted with that link's details....

Thanks very much!! :)

[yktan]

Great work Ap0s7le! :D
However, please note that this line is erronous too:
Content visible to registered users only.It should be:
Content visible to registered users only.There is no field in the links table with the name "NAME".

springdot, if the emails that you are getting are from "unknown" or without any "From" emaill address, you might want to have a look at this fix:
{deleted}

[yktan]

Also, here's a fix to send out notifications when links are deleted:


{deleted}

Regards,
YK

[achafik]

Correct!, looks like all three bugs are fixed :)

[springdot]

Content visible to registered users only.yktan - my emails all seem fine now actually - after making the change so the submission email was sent to admin, it seemed to fix the name in the email to the link owner as well. I don't understand it, but it works, so I'm happy!

I'm just about to make the mod to fix the link rejection/deletion email and then all should be fine!

Thanks a lot


James

[kulinar]

Content visible to registered users only.Line 530 looks like
Content visible to registered users only.
Should it be changed to
Content visible to registered users only.

[yktan]

Hi kulinar, can you try applying the changes stated in the following 2 threads and see if they work for you?

{deleted}

Regards,
YK

[minstrel]

Excellent work, yktan and Ap0s7le!

The fixes work as claimed! :D

One question now for my email tyemplates -- how do I include

1. the name of the submitter
2. the name of the link submitted
3. the category to which it was submitted

in my notifications to the submitter? I notice that this info is all included in the email to Admin. What are the variable names for each?

[yktan]

Hi minstrel, the following thread will help you with variables that you can use in notification emails:

{deleted}

[David]

I updated the 1st post of this thread. Please let me know if I missed anything.

[minstrel]

Content visible to registered users only.
Thanks, yktan - I was just coming back to say I'd found that thread.

Answers (for others who are curious):

1. {LINK_TITLE}
2. {LINK_URL}
3. ...not yet determined...

Suggestion: Include this information in the list of variables in the Email Templates box that can be included in the emails?

[Ap0s7le]

Thanks all, glad I could help.

yktan, you're right about the $data['NAME'] I just hadn't made the change.

Looks like we're nailing these down.

later

[yktan]

Yes Ap0s7le, I think we nailed them good! :)

[Ap0s7le]

Check out the thread

{deleted}

Thanks

[Ap0s7le]

Hey minstrel, I didn't see your above post concerning the CATEGORY_TITLE that you wanted to add in.

I have it in the Notify, nothing else. I figure it's the admins who'd want to know right away where it was rather than the person who submitted it.

You can try it out by doing this.
Open up "include/functions.php"

Find
Content visible to registered users only.
You can find that by searching the line "function send_submit_notifications"
Right below the above "return;" add the following.

Content visible to registered users only.


So the end result should look like this.
Content visible to registered users only.

And so of course you would access that variable by using Content visible to registered users only.

later

[minstrel]

Thanks, Casey.

I'll get some sleep first and then give it a try :D

[minstrel]

Hmmm.,.. that didn't work. Used in the linkowner notification email, {CATEGORY_TITLE} just shows up as {CATEGORY_TITLE} (the variable name itself rather than the actual name of the category).

Don't worry about it though -- I don't see this as a required feature at all, just an optional reminder to the submitter. The link owner SHOULD be able to find his own link... :shock:

[solutionsphp]

I just upgraded to RC4 (downloaded it today). These fixes still need to be applied, or was the RC4 package updated with them?

Looks awesome so far!! This app is quickly climbing the ranks to be the best in its class.

cheers
SAM :)

[trailblaza]

the current download does not have the fixes... you have to patch them yourself or download the RC5 floating around somewhere on this board (although it's not "official" it's the version with all the fixes)

lj.

[solutionsphp]

OK, thanks for the quick reply!
SAM :)

[trailblaza]

no problem :D

lj.

[kickass]

It seems the vast majority of the xhtml validation errors in php link directory generated pages are from unencoded characters such as ampersands (though not by any means all of them, and I hope you're working to fix that please! You'll gain much more respect in the coding community for generating clean xhtml code) . I also noticed that when I entered a category title that used an ampersand into the admin area when the script generated the page it did not encode it in the xhtml.

This can't be all that hard to fix on the scripting end (tedious maybe, but not hard!) Could you PLEASE fix it in the next version and get us that much closer to xhtml validation? It makes it so much easier to debug css when you're working with clean xhtml.

[David]

We've gone like 12 days with no update to the WebSVN, and I'm working to get an update, as there are a number of little fixes that have been left undone.

[kickass]

The default template needs two fixes to help toward achieving xhtml validation in addition to the unencoded character issue I posted earlier. The first one, in header.tpl is the first few lines, which contains the doctype and such. This is what it needs to be:


Content visible to registered users only.The second one is in main.tpl, and is the inline javascript, that needs to read like this in order for it to pass xhtml validation:

Content visible to registered users only.vkaryl did point out in this thread that this particular javascript throws an error in Opera, but she did test before I ran this bit thru tidy so it should be checked in Opera again.

{deleted}

The third fix is in the core code. XHTML 1.0 states that an ID cannot start with a numeral and if it does the document will not validate. On the actual linklist pages in generated xhtml source every single link has a code generated number ID. Any way to put ANY letter in front of them??? I know the numbers are in the dbase, but maybe you can dish a bit of code to handle this without going in and changing databases, which I understand is tantamount to devil worship and cannibalism in certain circles . . .

[vkaryl]

In Op 7.23 and 8.01:

Unknown context
Syntax error while loading: line 3 of inline script at http://kickasswebdesign.com/webgeekdir/ :
!='')a[i].onclick=count_link;functioncount_link(){i=newImag e
---------------------------------------------------^

appears in the Javascript error console when loading the PHPLD at http://kickasswebdesign.com/webgeekdir/

Does not prevent the page from loading....

[cvos]

hey guys - any idea when rc5 or the final will be out on this great dir:)

[Ap0s7le]

RC5 will be out soon.

Thanks

-Casey

[kickass]

If you click any of the headers at the top of the admin links table to change the sort order (ie categories) it results in this:
Content visible to registered users only.
The only way to get that admin page working again is to either figure out which cookie to delete OR reboot system.

Tell the truth, this is the only admin table I've tried this in, I dunno if the others give the same errors or not (like Categories Admin Table, for instance?)

Apache 1.3.33
Kernel 2.4.22-1.2199
PHP 4.4.0
Mysql 4.0.22

[David]

I know we have had this issue before, and there is a fix here on the forum. I'll see if I can find it.

Found:

{deleted}

[kickass]

It seems to have worked. Thanks.

[vkaryl]

Fix for the previously noted javascript error displaying in Op 7 and 8:

This is the original code -

{* Javascript for tracking link clicks *}
<script type="text/javascript">
//<![CDATA[
var root = '{$smarty.const.DOC_ROOT}';
{literal}
var a = document.getElementsByTagName("a");
for(i=0; i<a.length; i++)if(a[i].id != '')
a[i].onclick = count_link;
function count_link(){
i = new Image();
i.src= root+'/cl.php?id='+this.id;
return true;
}
{/literal}
//]]>
</script>

The fix is to remove a space between "new" and "Image", see corrected code as follows:

{* Javascript for tracking link clicks *}
<script type="text/javascript">
//<![CDATA[
var root = '{$smarty.const.DOC_ROOT}';
{literal}
var a = document.getElementsByTagName("a");
for(i=0; i<a.length; i++)if(a[i].id != '')
a[i].onclick = count_link;
function count_link(){
i = newImage();
i.src= root+'/cl.php?id='+this.id;
return true;
}
{/literal}
//]]>
</script>

Should take care of it....

[EDIT: note please that this code block is essentially the same in rc 5, 5.1, and 5.2 as in rc4. The correction as above needs to be made to any rc you are using since 4....]

[kickass]

Can you PLEASE sticky this dang thread so I don't have to keep scrolling way down to find it???